Skip to content

Escrow pallet#1094

Merged
Noc2 merged 10 commits intow3f:masterfrom
herou:master
Aug 8, 2022
Merged

Escrow pallet#1094
Noc2 merged 10 commits intow3f:masterfrom
herou:master

Conversation

@herou
Copy link
Copy Markdown
Contributor

@herou herou commented Jul 31, 2022

Project Abstract

We aim to build an Escrow pallet that will help communities to release funds easier to devs/teams
and the web3 community would have a simple escrow system implemented in web3.

For which grant level are you applying?

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied, renamed ( project_name.md) and updated.
  • I have read and understood the FAQs, application guidelines and announcement guidelines.
  • A BTC, Ethereum (USDT/USDC/DAI) or Polkadot/Kusama (aUSD) address for the payment of the milestones is provided inside the application.
  • I have read and acknowledge the terms and conditions.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted.
  • I prefer the discussion of this application to be in a private Element/Matrix channel. My username is: @_______

How Did You Hear About our grants program?

  • Social Media
  • Hackathon
  • Personal Recommendation
  • Substrate Builders Program
  • Investor/VC
  • Online Search
  • Other: _______

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 31, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Noc2
Noc2 suggested changes Aug 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. But you are currently adding two files to the repo. Could you remove one of them? Also, if you prefer a private discussion, could you share your element username?

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Aug 1, 2022
@Noc2 Noc2 self-assigned this Aug 1, 2022
@herou
Copy link
Copy Markdown
Contributor Author

herou commented Aug 1, 2022 •
edited
Loading

Thanks for the application. But you are currently adding two files to the repo. Could you remove one of them? Also, if you prefer a private discussion, could you share your element username?

Hi @Noc2. I deleted the unneeded file. I msg you directly on element : @elio.prifti:matrix.org

Noc2
Noc2 suggested changes Aug 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Are you aware of https://github.com/interlay/interbtc/blob/7942cfcd8a41013639285fe099285530438df3db/crates/escrow/src/lib.rs? Will all functions be implemented as part of a single pallet? Could you also add weights/benchmarking to the deliverables of the milestone?

@herou
Copy link
Copy Markdown
Contributor Author

herou commented Aug 2, 2022

Thanks for the update. Are you aware of https://github.com/interlay/interbtc/blob/7942cfcd8a41013639285fe099285530438df3db/crates/escrow/src/lib.rs? Will all functions be implemented as part of a single pallet? Could you also add weights/benchmarking to the deliverables of the milestone?

I have seen the link but my idea is something different. All the functions would be implemented as part of a single pallet. I added benchmarking to the deliverables of milestones.

@alxs alxs added the discussion private Discussion of application happens in private. label Aug 3, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 3, 2022

The applicant has requested the discussion of the application to happen in a private chat room.

Noc2
Noc2 previously approved these changes Aug 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I’m happy to support it and share it with the rest of the team.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed discussion private Discussion of application happens in private. labels Aug 4, 2022
takahser
takahser suggested changes Aug 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@herou you still have some leftover example texts from the template, e.g. "Milestone 1 Example". Could you fully replace these with your own texts (e.g. "Milestone 1 — Implement sign functionality")?

@herou
Copy link
Copy Markdown
Contributor Author

herou commented Aug 6, 2022

@herou you still have some leftover example texts from the template, e.g. "Milestone 1 Example". Could you fully replace these with your own texts (e.g. "Milestone 1 — Implement sign functionality")?

Done

@Noc2 Noc2 added discussion private Discussion of application happens in private. and removed changes requested The team needs to clarify a few things first. labels Aug 8, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 8, 2022

The applicant has requested the discussion of the application to happen in a private chat room.

@Noc2 Noc2 merged commit b3b9343 into w3f:master Aug 8, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 8, 2022

Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions.

Before you start, take a moment to read through our announcement guidelines for all communications related to the grant or make them known to the right person in your organisation. In particular, please don't announce the grant publicly before at least the first milestone of your project has been approved. At that point or shortly before, you can get in touch with us at grantsPR@web3.foundation and we'll be happy to collaborate on an announcement about the work you’re doing.

Lastly, please remember to let us know in case you run into any delays or deviate from the deliverables in your application. You can either leave a comment here or directly request to amend your application via PR. We wish you luck with your project! 🚀

@Gryczka Gryczka mentioned this pull request Aug 18, 2022
Merged
10 tasks
This was referenced Sep 9, 2022
Closed
Merged
@keeganquigley keeganquigley mentioned this pull request Sep 21, 2022
Merged
@takahser takahser mentioned this pull request Sep 22, 2022
Merged
This was referenced Sep 23, 2022
Closed
Merged
@keeganquigley keeganquigley mentioned this pull request Oct 13, 2022
Merged
@herou herou mentioned this pull request Oct 14, 2022
Merged
5 tasks
@herou herou mentioned this pull request Oct 24, 2022
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@takahser takahser takahser approved these changes

@Noc2 Noc2 Noc2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Noc2 Noc2

Labels

discussion private Discussion of application happens in private. ready for review The project is ready to be reviewed by the committee members.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@herou @CLAassistant @takahser @Noc2 @alxs