Skip to content

Substrate startkit GUI milestone #2 delivery
#57

Merged
semuelle merged 1 commit intow3f:masterfrom
ivorrr:master
Dec 23, 2020
Merged

Substrate startkit GUI milestone #2 delivery
#57
semuelle merged 1 commit intow3f:masterfrom
ivorrr:master

Conversation

@ivorrr
Copy link
Copy Markdown
Contributor

@ivorrr ivorrr commented Dec 4, 2020

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is done by the same account, which is responsible for the pull request of the accepted application.
  • In the case of acceptance, the payment will be transferred to the initial BTC payment address.

@Noc2
Copy link
Copy Markdown
Contributor

Noc2 commented Dec 4, 2020

Thanks for the delivery. We will look into it as soon as possible.

@semuelle
Copy link
Copy Markdown
Contributor

Hi @ivorrr, I am trying to evaluate your code locally, but there are no pallets or templates showing in the menu. Can you advise?

image

@pajicf
Copy link
Copy Markdown

pajicf commented Dec 14, 2020

Hi @semuelle,

Could you please check if the REACT_APP_API_BASE_URL variable in your .env file is pointing to the right address of the backend (eg. http://localhost:3001) and if the backend instance is running?

@semuelle
Copy link
Copy Markdown
Contributor

Hi @pajicf & @ivorrr, please see my evaluation notes here.

Everything except the tests is already ticked off. Could you just add a few more tests, such as for the services on the backend and a few more integration tests?

@ivorrr
Copy link
Copy Markdown
Contributor Author

ivorrr commented Dec 15, 2020

@semuelle Sure. It was part of the plan to add more tests. Great to hear that everything else is working as you expected. We will continue to work on it this week, and we will get back to you when we finish.

@pajicf
Copy link
Copy Markdown

pajicf commented Dec 23, 2020

Hi @semuelle, we have implemented the requested changes from the evaluation notes.
Please pull the changes and check it out.
P.S. you'll need to update the .env file with additional new variables which can be found in the .env.example

@semuelle
Copy link
Copy Markdown
Contributor

@ivorrr & @pajicf,
thanks for following up on the tests and installation requirements. That's a nice set of tests. :)
I updated my evaluation notes and your milestone is now accepted. 🎉

Your invoice will be forwarded for processing.

@semuelle semuelle merged commit b9d2cc2 into w3f:master Dec 23, 2020
@RouvenP
Copy link
Copy Markdown

RouvenP commented Jan 8, 2021

hi all, we sent a test transaction. Could you please confirm if received?

@pajicf
Copy link
Copy Markdown

pajicf commented Jan 8, 2021

Hi @RouvenP , we received 0.001BTC from 35pRT........SKMt

@RouvenP
Copy link
Copy Markdown

RouvenP commented Jan 8, 2021

Thanks for confirming @pajicf. we sent the payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants