identity directory milestone 2 delivery#230
Merged
alxs merged 5 commits intow3f:masterfrom Sep 22, 2021
Merged
Conversation
29c20b3 to
f3219c1
Compare
6 tasks
Contributor
|
Here as well, it would be great if you could update the links to point to where each of the deliverables is implemented. |
alxs
suggested changes
Aug 26, 2021
| | Number | Deliverable | Link | Notes | | ||
| | ------------- | ------------- | ------------- |------------- | | ||
| | 1. | Implement logic for sending tokens | https://github.com/Shard-Labs/identity-directory/blob/main/src/store/actions.ts#L250 | Implement logic for sending tokens; retrieve balance, parse inputs, display transaction fee, create the transfer transaction. | | ||
| | 2. | Make the web service work offline | https://github.com/Shard-Labs/identity-directory/blob/main/src/store/actions.ts#L171 https://github.com/Shard-Labs/identity-directory/blob/main/src/components/navigation/SideBar.vue#L15 | Web service can be used in offline mode; the user can specify a local node to which will the service connect. | |
Contributor
There was a problem hiding this comment.
What is it that these two links are meant to show? Besides, could you please add instructions to the README to run this with a local node?
Contributor
Author
There was a problem hiding this comment.
These links were not good anymore because new commits moved lines of code. It is fixed now.
|
|
||
| | Number | Deliverable | Link | Notes | | ||
| | ------------- | ------------- | ------------- |------------- | | ||
| | 1. | Implement logic for sending tokens | https://github.com/Shard-Labs/identity-directory/blob/main/src/store/actions.ts#L250 | Implement logic for sending tokens; retrieve balance, parse inputs, display transaction fee, create the transfer transaction. | |
Contributor
There was a problem hiding this comment.
- Could you point me to the unit tests for this functionality?
- It's currently only possible to type in integer amounts
- The few times I was able to see the transaction details, it always had a value of 0. Most of the time it just shows the raw data, but I think that's an issue with polkadot{.js}
Contributor
Author
There was a problem hiding this comment.
- There is no unit test for that functionality since we are only calling external module to send tokens.
- Fixed now
- Send token function sends correct value of tokens (tested)
Contributor
|
Thanks @Jakic007, the milestone is hereby a pass. You can find my evaluation notes here. I'll forward your invoice for processing. |
|
hi @Jakic007, we just transferred the payment for M2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone Delivery Checklist
Link to the application PR: w3f/Grants-Program#255