Conversation
|
Thanks for the delivery. We will look into it as soon as possible. |
Update docker image link
|
Hi @apron2050, two of the repos mentioned in your delivery do not contain a license. If they are part of a milestone, they need to be under one of the licenses mentioned in the guidelines. Could you fix that, please? |
Hi @semuelle , thank you for your kind remind. All the missing license files are added. Sorry for the late reply. We are preparing for the Polkadot Hackathon Asia these days. Hope we can make it. |
|
I'm putting this temporarily on hold due to parallel participation in the hackathon. The hackathon organisers will contact you regarding further steps. |
|
|
Hi @apron2050. Since the contracts are a significant part of your milestone, I have to ask you to add one of the open source licenses mentioned in our guidelines to the |
|
Hi @apron2050, one more request: I am trying to upload the services market contract, but I am getting the following error on There are also a couple of missing or incomplete steps, such as Can you please check that the tutorial is complete and reproducible? |
Thank you for the information. The license files are added now. |
Sorry for the inconvenience! The error is due to bugs in Paste the above config in Let me recheck all the steps in the tutorial. I have added a tool named |
|
Since your grant agreement contains only one milestone, what do you mean by Can you explain what work you have done instead ( |
Yes, we want to implement the SDK in the future, the schedule is still not planned yet, but not included in this grant, since there is no use case of the SDK when we tried to implement this milestone.
In this milestone, we provide the access entry point for Metamask (the ethereum wallet), Truffle (the solidity development framework), and Hardhat (another solidity development framework) in the case of providing RPC service for Heco and BSC. The words |
I don't think an EVM RPC API is an adequate replacement for an Substrate node SDK. If you wish to remove the SDK from the list of deliverables, you can submit an amendment of the original contract. However, this will need to be approved by the committee and will probably also result in an adjustment of the price. You could also submit an amendment that moves the SDK to a later milestone. In any case, I cannot approve the delivery as it is, although I have already signed off on the rest of the deliverables. Please let me know how you would like to proceed. |
Update docker related links and tutorial link.
Hi @semuelle , thanks for the suggestions. We have updated the tutorial and the docker-related links. Now everything is okay to run. Regarding the SDK part, in the beginning, I thought we may need to encrypt the transmission between the service user and the service provider, but when we made some progress, I found implement such an SDK to encrypt the transmission will force the users to use the specific client we are not able to provide right now, and it's quite bad to users in the current state. Maybe I should update the delivery of SDK with the above sentences or submit an update to the grant application? |
Apron SDK is not a Substrate Node SDK. It's a client-side SDK, it's planned to encrypt and protect the transmission between the client-side application and the services provider side as we thought in the beginning. But in the current state,
|
Maybe I misunderstood the purpose of the SDK. I thought the Apron SDK would provide convenience functions to access the Apron smart contracts through the Substrate node RPC. Then it would be quite simple to write a wrapper to simplify the contract calls. That's what I gathered from your architecture sketch. |
Update links for marketplace
Thanks for the quick reply. Sorry, it's not detailed the SDK function in that architecture figure. |
|
@semuelle Just updated the links in the delivery doc. Hope it could be helpful for the review of deliverables. |
|
I saw the updates on the documentation, thank you. With regard to the SDK, you will have to make an amendment to the contract by either removing it or delaying it until a second milestone (as previously mentioned). Let me know how you would like to proceed. |
Thank you. I think maybe make an amendment to the contract by removing it and reduce the price. |
Please find the PR by remove SDK and reduce the price of the milestone. |
update deliverables according to grant application
|
Hi @semuelle , could you continue the review? We have updated the deliverables in this PR. |
|
Hi @apron2050, your smart contract tests currently test only whether a service was added or not. No value checks, no edge cases, no error handling. Given that this is your only milestone, I would like to ask you to expand those. |
Thanks for the advice. We will add it asap and will come to you when new cases added. |
|
Hi @semuelle, we have added several test cases, and also created an issue for a special case which may not be the blocking issue here. Here is the issue use-ink/ink#747 Could you help to continue the review? |
|
Hi @apron2050, I am happy to report that your milestone has passed. I have forwarded your invoice for processing. |
|
Hi @apron2050, the date on your invoice shows 2022. Could you send an updated invoice? |
|
Hi @apron2050 we sent a test transaction of 0.001 BTC. Could you confirm if received? |
Hi @semuelle How can I update the invoice? Resubmit the google form? |
Hi @RouvenP , thank you. I have received 0.001 BTC. |
|
Hi @semuelle, the date has been corrected, and the new pdf is submitted in the google form. Thank you! |
|
Thanks, @apron2050, I have forwarded the invoice. |
|
@apron2050 thanks for confirming. We sent the remainder. |
|
Hi @apron2050, could you send an invoice with the updated BTC amount? |
|
Hi @apron2050: we noticed a discrepancy between the invoice you sent us (1.2 BTC) and your application (0.73 BTC). We kindly ask you to
|
Milestone Delivery Checklist