Skip to content

Apron Network Milestone 1#112

Merged
semuelle merged 6 commits intow3f:masterfrom
Apron-Network:master
Mar 29, 2021
Merged

Apron Network Milestone 1#112
semuelle merged 6 commits intow3f:masterfrom
Apron-Network:master

Conversation

@Toney2000
Copy link
Copy Markdown
Contributor

@Toney2000 Toney2000 commented Mar 9, 2021

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is done by the same account, which is responsible for the pull request of the accepted application.
  • In the case of acceptance, the payment will be transferred to the initial BTC payment address.
  • The delivery is according to the milestone delivery guidelines.

@Noc2
Copy link
Copy Markdown
Contributor

Noc2 commented Mar 9, 2021

Thanks for the delivery. We will look into it as soon as possible.

Update docker image link
@semuelle
Copy link
Copy Markdown
Contributor

Hi @apron2050, two of the repos mentioned in your delivery do not contain a license. If they are part of a milestone, they need to be under one of the licenses mentioned in the guidelines. Could you fix that, please?

@Toney2000
Copy link
Copy Markdown
Contributor Author

Hi @apron2050, two of the repos mentioned in your delivery do not contain a license. If they are part of a milestone, they need to be under one of the licenses mentioned in the guidelines. Could you fix that, please?

Hi @semuelle , thank you for your kind remind. All the missing license files are added. Sorry for the late reply. We are preparing for the Polkadot Hackathon Asia these days. Hope we can make it.

@mmagician
Copy link
Copy Markdown
Contributor

I'm putting this temporarily on hold due to parallel participation in the hackathon. The hackathon organisers will contact you regarding further steps.

@Toney2000
Copy link
Copy Markdown
Contributor Author

I'm putting this temporarily on hold due to parallel participation in the hackathon. The hackathon organisers will contact you regarding further steps.
@mmagician Thank you for information.

@semuelle
Copy link
Copy Markdown
Contributor

Hi @apron2050. Since the contracts are a significant part of your milestone, I have to ask you to add one of the open source licenses mentioned in our guidelines to the apron-contracts repository.

@mmagician mmagician removed the on hold label Mar 23, 2021
@semuelle
Copy link
Copy Markdown
Contributor

Hi @apron2050, one more request:

I am trying to upload the services market contract, but I am getting the following error on putCode:

1002: Verification Error: Execution: Could not convert parameter `tx` between node and runtime: No such variant in enum MultiSignature: RuntimeApi, Execution: Could not convert parameter `tx` between node and runtime: No such variant in enum MultiSignature

There are also a couple of missing or incomplete steps, such as docker build -t apron-node instead of docker build . -t apron-node, the submodule initialisation and warnings in the build script:

copy to ../release
cp: cannot stat '/apron/apron-contracts/services_statistics/target/services_statistics.wasm': No such file or directory
cp: cannot stat '/apron/apron-contracts/services_statistics/target/services_statistics.contract': No such file or directory
cp: cannot stat '/apron/apron-contracts/services_statistics/target/metadata.json': No such file or directory

Can you please check that the tutorial is complete and reproducible?

@Toney2000
Copy link
Copy Markdown
Contributor Author

Hi @apron2050. Since the contracts are a significant part of your milestone, I have to ask you to add one of the open source licenses mentioned in our guidelines to the apron-contracts repository.

Thank you for the information. The license files are added now.

@Toney2000
Copy link
Copy Markdown
Contributor Author

Hi @apron2050, one more request:

I am trying to upload the services market contract, but I am getting the following error on putCode:

1002: Verification Error: Execution: Could not convert parameter `tx` between node and runtime: No such variant in enum MultiSignature: RuntimeApi, Execution: Could not convert parameter `tx` between node and runtime: No such variant in enum MultiSignature

There are also a couple of missing or incomplete steps, such as docker build -t apron-node instead of docker build . -t apron-node, the submodule initialisation and warnings in the build script:

copy to ../release
cp: cannot stat '/apron/apron-contracts/services_statistics/target/services_statistics.wasm': No such file or directory
cp: cannot stat '/apron/apron-contracts/services_statistics/target/services_statistics.contract': No such file or directory
cp: cannot stat '/apron/apron-contracts/services_statistics/target/metadata.json': No such file or directory

Can you please check that the tutorial is complete and reproducible?

Sorry for the inconvenience!

1002: Verification Error: Execution: Could not convert parameter `tx` between node and runtime: No such variant in enum MultiSignature: RuntimeApi, Execution: Could not convert parameter `tx` between node and runtime: No such variant in enum MultiSignature

The error is due to bugs in polkadot js apps. Here is the wa

{
  "Address": "AccountId",
  "LookupSource": "AccountId"
}

Paste the above config in Setting -> Developer.

Let me recheck all the steps in the tutorial. I have added a tool named apron-deployer to deploy and run all components with scripts. The tutorial will be updated soon and rechecked. Once we complete the tutorial, I will come to you ASAP.

@semuelle
Copy link
Copy Markdown
Contributor

Since your grant agreement contains only one milestone, what do you mean by Later with backend application, we need to provide the related SDK to handle load balance? You are still planning to implement the SDK, but not as part of the grant?

Can you explain what work you have done instead (we choose to support metamask and other developement framework)?

@Toney2000
Copy link
Copy Markdown
Contributor Author

Since your grant agreement contains only one milestone, what do you mean by Later with backend application, we need to provide the related SDK to handle load balance? You are still planning to implement the SDK, but not as part of the grant?

Yes, we want to implement the SDK in the future, the schedule is still not planned yet, but not included in this grant, since there is no use case of the SDK when we tried to implement this milestone.

Can you explain what work you have done instead (we choose to support metamask and other developement framework)?

In this milestone, we provide the access entry point for Metamask (the ethereum wallet), Truffle (the solidity development framework), and Hardhat (another solidity development framework) in the case of providing RPC service for Heco and BSC. The words we choose to support metamask and other development framework are unrelated to this milestone as far as we see, can we remove it?

@semuelle
Copy link
Copy Markdown
Contributor

providing RPC service for Heco and BSC.

I don't think an EVM RPC API is an adequate replacement for an Substrate node SDK. If you wish to remove the SDK from the list of deliverables, you can submit an amendment of the original contract. However, this will need to be approved by the committee and will probably also result in an adjustment of the price.

You could also submit an amendment that moves the SDK to a later milestone. In any case, I cannot approve the delivery as it is, although I have already signed off on the rest of the deliverables.

Please let me know how you would like to proceed.

Update docker related links and tutorial link.
@Toney2000
Copy link
Copy Markdown
Contributor Author

providing RPC service for Heco and BSC.

I don't think an EVM RPC API is an adequate replacement for an Substrate node SDK. If you wish to remove the SDK from the list of deliverables, you can submit an amendment of the original contract. However, this will need to be approved by the committee and will probably also result in an adjustment of the price.

You could also submit an amendment that moves the SDK to a later milestone. In any case, I cannot approve the delivery as it is, although I have already signed off on the rest of the deliverables.

Please let me know how you would like to proceed.

Hi @semuelle , thanks for the suggestions. We have updated the tutorial and the docker-related links. Now everything is okay to run.

Regarding the SDK part, in the beginning, I thought we may need to encrypt the transmission between the service user and the service provider, but when we made some progress, I found implement such an SDK to encrypt the transmission will force the users to use the specific client we are not able to provide right now, and it's quite bad to users in the current state.

Maybe I should update the delivery of SDK with the above sentences or submit an update to the grant application?

@Toney2000
Copy link
Copy Markdown
Contributor Author

providing RPC service for Heco and BSC.

I don't think an EVM RPC API is an adequate replacement for an Substrate node SDK. If you wish to remove the SDK from the list of deliverables, you can submit an amendment of the original contract. However, this will need to be approved by the committee and will probably also result in an adjustment of the price.

Apron SDK is not a Substrate Node SDK. It's a client-side SDK, it's planned to encrypt and protect the transmission between the client-side application and the services provider side as we thought in the beginning. But in the current state, ssl is good enough for this purpose.

You could also submit an amendment that moves the SDK to a later milestone. In any case, I cannot approve the delivery as it is, although I have already signed off on the rest of the deliverables.

Please let me know how you would like to proceed.

@semuelle
Copy link
Copy Markdown
Contributor

But in the current state, ssl is good enough for this purpose.

Maybe I misunderstood the purpose of the SDK. I thought the Apron SDK would provide convenience functions to access the Apron smart contracts through the Substrate node RPC. Then it would be quite simple to write a wrapper to simplify the contract calls. That's what I gathered from your architecture sketch.

Update links for marketplace
@Toney2000
Copy link
Copy Markdown
Contributor Author

But in the current state, ssl is good enough for this purpose.

Maybe I misunderstood the purpose of the SDK. I thought the Apron SDK would provide convenience functions to access the Apron smart contracts through the Substrate node RPC. Then it would be quite simple to write a wrapper to simplify the contract calls. That's what I gathered from your architecture sketch.

Thanks for the quick reply. Sorry, it's not detailed the SDK function in that architecture figure.
To call the contracts is already handled by the projectpolkadot js api which is used in our demo too.

@Toney2000
Copy link
Copy Markdown
Contributor Author

@semuelle Just updated the links in the delivery doc. Hope it could be helpful for the review of deliverables.

@semuelle
Copy link
Copy Markdown
Contributor

I saw the updates on the documentation, thank you.

With regard to the SDK, you will have to make an amendment to the contract by either removing it or delaying it until a second milestone (as previously mentioned). Let me know how you would like to proceed.

@Toney2000
Copy link
Copy Markdown
Contributor Author

I saw the updates on the documentation, thank you.

With regard to the SDK, you will have to make an amendment to the contract by either removing it or delaying it until a second milestone (as previously mentioned). Let me know how you would like to proceed.

Thank you. I think maybe make an amendment to the contract by removing it and reduce the price.

@Toney2000
Copy link
Copy Markdown
Contributor Author

I saw the updates on the documentation, thank you.

With regard to the SDK, you will have to make an amendment to the contract by either removing it or delaying it until a second milestone (as previously mentioned). Let me know how you would like to proceed.

Please find the PR by remove SDK and reduce the price of the milestone.
w3f/Grants-Program#331

update deliverables according to grant application
@Toney2000
Copy link
Copy Markdown
Contributor Author

Hi @semuelle , could you continue the review? We have updated the deliverables in this PR.

@semuelle
Copy link
Copy Markdown
Contributor

Hi @apron2050, your smart contract tests currently test only whether a service was added or not. No value checks, no edge cases, no error handling. Given that this is your only milestone, I would like to ask you to expand those.

@Toney2000
Copy link
Copy Markdown
Contributor Author

Hi @apron2050, your smart contract tests currently test only whether a service was added or not. No value checks, no edge cases, no error handling. Given that this is your only milestone, I would like to ask you to expand those.

Thanks for the advice. We will add it asap and will come to you when new cases added.

@Toney2000
Copy link
Copy Markdown
Contributor Author

Hi @semuelle, we have added several test cases, and also created an issue for a special case which may not be the blocking issue here. Here is the issue use-ink/ink#747

Could you help to continue the review?

@semuelle
Copy link
Copy Markdown
Contributor

Hi @apron2050, I am happy to report that your milestone has passed.

I have forwarded your invoice for processing.

@semuelle semuelle merged commit ba638d4 into w3f:master Mar 29, 2021
@semuelle
Copy link
Copy Markdown
Contributor

Hi @apron2050, the date on your invoice shows 2022. Could you send an updated invoice?

@RouvenP
Copy link
Copy Markdown

RouvenP commented Apr 1, 2021

Hi @apron2050 we sent a test transaction of 0.001 BTC. Could you confirm if received?

@Toney2000
Copy link
Copy Markdown
Contributor Author

Hi @apron2050, the date on your invoice shows 2022. Could you send an updated invoice?

Hi @semuelle How can I update the invoice? Resubmit the google form?

@Toney2000
Copy link
Copy Markdown
Contributor Author

Hi @apron2050 we sent a test transaction of 0.001 BTC. Could you confirm if received?

Hi @RouvenP , thank you. I have received 0.001 BTC.

@Toney2000
Copy link
Copy Markdown
Contributor Author

Hi @semuelle, the date has been corrected, and the new pdf is submitted in the google form. Thank you!

@semuelle
Copy link
Copy Markdown
Contributor

semuelle commented Apr 3, 2021

Thanks, @apron2050, I have forwarded the invoice.

@RouvenP
Copy link
Copy Markdown

RouvenP commented Apr 7, 2021

@apron2050 thanks for confirming. We sent the remainder.

@semuelle
Copy link
Copy Markdown
Contributor

Hi @apron2050, could you send an invoice with the updated BTC amount?

@RouvenP
Copy link
Copy Markdown

RouvenP commented Apr 12, 2021

Hi @apron2050: we noticed a discrepancy between the invoice you sent us (1.2 BTC) and your application (0.73 BTC). We kindly ask you to

  1. return the overpaid amount of 0.47 BTC to bc1qtwznev6ft4skmyuee8yqg495a6f9sk243xdfwghfqhl72vyudwks4sgmc3
  2. send us an invoice with the correct amount as requested by semuelle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants