Skip to content

fix(tokeniser): prevent escaping reserved identifiers#403

Merged
saschanaz merged 2 commits intogh-pagesfrom
reserved-identifiers
Aug 31, 2019
Merged

fix(tokeniser): prevent escaping reserved identifiers#403
saschanaz merged 2 commits intogh-pagesfrom
reserved-identifiers

Conversation

@saschanaz
Copy link
Copy Markdown
Member

@saschanaz saschanaz commented Aug 31, 2019 •
edited
Loading

Because the spec says:

For all of these constructs, the identifier is the value of the identifier token with any leading U+005F LOW LINE ("_") character (underscore) removed.

The identifier of any of the abovementioned IDL constructs must not be "constructor", "toString", or begin with a U+005F LOW LINE ("_") character. These are known as reserved identifiers.

This patch includes:

  • A relevant test

marcoscaceres
marcoscaceres approved these changes Aug 31, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@saschanaz saschanaz merged commit 08fee14 into gh-pages Aug 31, 2019
@saschanaz saschanaz deleted the reserved-identifiers branch August 31, 2019 11:24
@saschanaz saschanaz mentioned this pull request Oct 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saschanaz @marcoscaceres