Add tests for PaymentResponse.retry()#11101
Merged
marcoscaceres merged 9 commits intomasterfrom Aug 13, 2018
Merged
Conversation
7 tasks
7 tasks
6182c4c to
94ecfa4
Compare
Contributor
Author
|
@mnoorenberghe, when possibly, would appreciate review of these tests - so I can land the first part of |
9013a3a to
c8d8dd5
Compare
Contributor
Author
|
@domenic, I added two manual (😿) tests for "fully active", based on
|
Contributor
Author
|
Gentle ping, fellow reviewers 🍰 |
7968b67 to
3f206ae
Compare
9f479ea to
f6e2171
Compare
5 tasks
f6e2171 to
a8edd05
Compare
2 tasks
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 2, 2018
This patch only includs an implementation of PaymentResponse.retry() in renderer and mojo side. We should implement UI in browser side in follow up CLs. Once this patch is applied, most test cases will be passed except when the UI is required. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wayZGnuBkrI Test: //components/payments/core/payments_validators_unittest.cc //third_party/blink/renderer/modules/payments/payments_validators_test.cc web-platform-tests/wpt#11101 Bug: 861704 Change-Id: I8a644a32ed589a2292ad021f5699105482ad9dd1 Reviewed-on: https://chromium-review.googlesource.com/1142045 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#580126}
Contributor
Author
|
@domenic, any chance you could review these? I'm struggling to find people to help me with reviewing tests 😢 |
Member
|
Sorry, I don't have the bandwidth for this :(. Hopefully anyone who's planning to implement would be willing to review? |
Contributor
Author
|
Np, maybe @rsolomakhin? |
Collaborator
|
There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
rsolomakhin
approved these changes
Aug 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.