Skip to content

feat: add VcIssuerMock.json (a testable mock issuer implementation)#53

Merged
BigBlueHat merged 2 commits intow3c:mainfrom
laysakura:feat/add-VcIssuerMock
Aug 5, 2024
Merged

feat: add VcIssuerMock.json (a testable mock issuer implementation)#53
BigBlueHat merged 2 commits intow3c:mainfrom
laysakura:feat/add-VcIssuerMock

Conversation

@laysakura
Copy link
Copy Markdown
Contributor

Already tested that all vc2.0 tests passed.

The test target architecture and deployment settings are documented in: https://github.com/laysakura/vc-issuer-mock/blob/main/crates/vc-issuer-mock-core/tests-vc-api/README.md

@aljones15 aljones15 requested a review from BigBlueHat July 30, 2024 15:27
@aljones15
Copy link
Copy Markdown
Collaborator

aljones15 commented Jul 30, 2024

this is cool thanks

Copy link
Copy Markdown
Collaborator

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible the issuer should sign with a did key and hence the issuer.id should be that did key.

@laysakura laysakura force-pushed the feat/add-VcIssuerMock branch from 5ddde40 to e669fea Compare July 31, 2024 03:22
@laysakura laysakura requested a review from aljones15 July 31, 2024 03:24
@aljones15
Copy link
Copy Markdown
Collaborator

@laysakura I like your implementation, but you list it as a mock implementation. How is this a mock? As it is currently tagged it would end up the report here: https://w3c.github.io/vc-data-model-2.0-test-suite/

Are you ok with your implementation showing up in that report? Maybe you should mark it as a beta or an alpha if your implementation does actually really sign and verify 2.0 VCs.

@laysakura
Copy link
Copy Markdown
Contributor Author

laysakura commented Jul 31, 2024

@aljones15 Thank you for your feedback.

To clarify, this implementation is designed to provide a VC-API for Issuers that can be used in unit tests by those working with VCs (such as Issuer Coordinators or Holder Coordinators in VC-API terminology). It does actually sign VCs in accordance with VCDM v2.0 specifications.

With these clarifications, I would be comfortable with this implementation appearing in the report you mentioned. If there are no further concerns, I hope it can be included.

@aljones15
Copy link
Copy Markdown
Collaborator

@laysakura More than happy to have another implementation so feel free to merge, but do keep in mind mock implies a fake issuer, which might create misunderstandings about what is mocked with your issuer and verifier.

@BigBlueHat
Copy link
Copy Markdown
Member

Thank you for building this, @laysakura! I think it's a great addition to the test suite results and a huge asset for folks wanting to wrap their implementations in VC-API for use with the test suites (or beyond).

In addition to adding it here, I hope to also promote it to other implementers who need this sort of wrapping approach--which should further lower the bar for implementers to get added to the test suite.

Much appreciated, @laysakura! 🙇

@BigBlueHat BigBlueHat merged commit adaa8f7 into w3c:main Aug 5, 2024
@laysakura laysakura deleted the feat/add-VcIssuerMock branch August 5, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants