Remove recommendation to localize sheet based on body element#896
Merged
marcoscaceres merged 2 commits intogh-pagesfrom Feb 12, 2020
Merged
Remove recommendation to localize sheet based on body element#896marcoscaceres merged 2 commits intogh-pagesfrom
marcoscaceres merged 2 commits intogh-pagesfrom
Conversation
Member
Author
|
@janiceshiu, when you can, could you check this to see if it makes sense (and for typos/grammar)? Thanks! 🙏 |
janiceshiu
suggested changes
Jan 28, 2020
Contributor
janiceshiu
left a comment
There was a problem hiding this comment.
would be lovely to get some things clarified. also suggested some rewordings to make the text clearer ^^
Co-Authored-By: Janice Shiu <16640692+janiceshiu@users.noreply.github.com>
Member
Author
|
@ianbjacobs, over to you for a final read. |
ianbjacobs
approved these changes
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #895
The following tasks have been completed:
Optional, impact on Payment Handler spec?
None.
Preview | Diff