Clarify when the user can abort the payment request algorithm#810
Clarify when the user can abort the payment request algorithm#810marcoscaceres merged 4 commits intogh-pagesfrom
Conversation
|
So, we had in there that there could be a timeout or some other means of aborting. However, I think we were going down the wrong path... I've routed the "timeout" and the user hitting "esc" down the "user aborts the payment request" path instead. I also removed the "[[updating]]" check to allow for this. |
|
@domenic, if you have time, can you please sanity check this? |
domenic
left a comment
There was a problem hiding this comment.
The duplication between "user aborts the payment request" and "abort the update" made this hard to review, but in the end I think the switch to that algorithm is fine. We should consider deduplicating those two algorithms though, if we can.
|
Filed bug about de-dupe abort the update and user aborts. #814 |
1005fdf to
d5141c1
Compare
|
As this makes provisions for an optional UI feature (a "cancel" button or user triggered action, like a hitting "esc"), I'm ok with merging this as is. It doesn't really add any new conformance requirements. It just clarifies behavior that matches what browsers already do. |
closes #796
The following tasks have been completed:
Implementation commitment:
Optional, Impact on Payment Handler spec?
None
Preview | Diff