Support fine-grained errors for payment methods#752
Conversation
|
On Basic Card side: w3c/payment-method-basic-card#58 |
domenic
left a comment
There was a problem hiding this comment.
LGTM with nits editorially. Unsure on consensus status.
index.html
Outdated
| <var>retryPromise</var>. | ||
| </li> | ||
| <li data-link-for="PaymentValidationErrors">If | ||
| <var>errorFields</var>'s <a>paymentMethod</a> member was passed, and |
There was a problem hiding this comment.
"was passed" -> "is present"
index.html
Outdated
| <a>payment method</a>, then <a data-cite= | ||
| "!WEBIDL#dfn-convert-ecmascript-to-idl-value">convert</a> | ||
| <var>errorFields</var> <a>paymentMethod</a> to an IDL value. | ||
| Otherwise, <a data-cite= |
There was a problem hiding this comment.
Unsure whether this buys anything, versus just ignoring it. Maybe it's useful for web-based payment handlers??
There was a problem hiding this comment.
Yeah, that's what I was thinking... not all payment handlers will be formally specified, so this allows stuff to be passed to "https://bob.pay".
index.html
Outdated
| if required by the specification that defines <var>response</var>'s | ||
| <a>payment method</a>, then <a data-cite= | ||
| "!WEBIDL#dfn-convert-ecmascript-to-idl-value">convert</a> | ||
| <var>errorFields</var> <a>paymentMethod</a> to an IDL value. |
There was a problem hiding this comment.
Maybe "to an IDL value of the type specified there" or similar?
index.html
Outdated
| <dfn>paymentMethod</dfn> member | ||
| </dt> | ||
| <dd> | ||
| A payment method specific error. See, for example, |
b30c368 to
842812c
Compare
|
Thanks for checking on status. We have an implementer's call wrt this and other features coming up on the 18th. |
|
Added link to Gecko tracking bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1473081). |
842812c to
0817937
Compare
|
|
|
YAY!!! WELCOME BACKK!!!! |
|
THANKS! |
|
Hey @rsolomakhin see email from Ian just now, too. ;-) |
|
Just missed the email and the meeting, sorry! I will join the next one. |
|
@rsolomakhin, when you get to it, could you drop in a tracking bug for Blink? Same for any other bugs. |
|
@marcoscaceres, done. What's the meaning of the checkbox? |
Not much. It’s satisfying to click tho. |
0817937 to
ae06907
Compare
|
As this depends on payment method, I'll test this as part of Basic Card: w3c/payment-method-basic-card#58 |
closes #727
The following tasks have been completed:
Implementation commitment:
Impact on Payment Handler spec?
See: w3c/web-based-payment-handler#306
So we can do, for example:
Preview | Diff