Skip to content

Add error member to PaymentValidationErrors#747

Merged
marcoscaceres merged 1 commit intogh-pagesfrom
error_member
Aug 10, 2018
Merged

Add error member to PaymentValidationErrors#747
marcoscaceres merged 1 commit intogh-pagesfrom
error_member

Conversation

@marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jul 5, 2018 •
edited by pr-preview bot
Loading

closes #729

The following tasks have been completed:

Implementation commitment:

  • Safari - already implemented.
  • Chrome
  • Firefox
  • Edge (public signal)

Impact on Payment Handler spec?

Preview | Diff

domenic
domenic approved these changes Jul 9, 2018
View reviewed changes
Copy link
Collaborator

@domenic domenic left a comment •
edited by marcoscaceres
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although, does this feature have consensus? #729 was a bit light on details.

Also will need rebase.

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Jul 24, 2018

@rsolomakhin, could you confirm that this is ok from the Blink side? We are planning to implement in Gecko. @aestes said this was ok to support in WebKit.

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Jul 24, 2018

Gecko tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1473081

rsolomakhin
rsolomakhin approved these changes Jul 25, 2018
View reviewed changes
Copy link
Collaborator

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcoscaceres marcoscaceres removed the request for review from mnoorenberghe July 26, 2018 08:25
@marcoscaceres marcoscaceres mentioned this pull request Aug 10, 2018
Merged
@marcoscaceres
Copy link
Member Author

marcoscaceres commented Aug 10, 2018

Sent test web-platform-tests/wpt#12394

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Aug 10, 2018

Documented https://developer.mozilla.org/en-US/docs/Web/API/PaymentResponse/retry#Parameters

@marcoscaceres marcoscaceres merged commit 0273c79 into gh-pages Aug 10, 2018
@marcoscaceres marcoscaceres deleted the error_member branch August 10, 2018 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenic domenic domenic approved these changes

@rsolomakhin rsolomakhin rsolomakhin approved these changes

Assignees

No one assigned

Labels

needs tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add generic error member for .retry()

3 participants

@marcoscaceres @domenic @rsolomakhin