Feat: allow show() to take optional detailsPromise#672
Feat: allow show() to take optional detailsPromise#672marcoscaceres merged 2 commits intogh-pagesfrom
Conversation
domenic
left a comment
There was a problem hiding this comment.
Elsewhere it says
SHOULD re-enable user interface elements that might have been disabled in the steps above if appropriate.
this should probably say "prior to running this algorithm" instead of "in the steps above"
LGTM with nits
index.html
Outdated
| <li>Set <var>request</var>.<a>[[\updating]]</a> to true. | ||
| </li> | ||
| <li>Disable the user interface user interface that will allow the | ||
| user to interact with the <var>handlers</var> and run the |
14f3433 to
7ab14be
Compare
|
Thanks again for the review, @domenic! |
|
Part 1 of tests web-platform-tests/wpt#9617 |
|
Tests are complete, awaiting review on: Part 1 - rejects. @aestes, not sure if it helps you much, but I added ApplePay as a payment method identifier to the tests. Let me know if there is anything I can do in web platform tests to make it easier to test in WebKit/Safari. |
8c72edc to
dae9275
Compare
|
I've added MDN documentation for this. |
7ff1539 to
486191f
Compare
486191f to
93c2f5e
Compare
|
@ianbjacobs, could you kindly please request the specification be republished. |
|
@marcoscaceres, request sent today for 1 March publication. |
closes #645
Implementer issues filed:
Preview | Diff