Clarify fxl dimensions must be in first viewport meta tag#2503
Merged
mattgarrish merged 2 commits intomainfrom Dec 14, 2022
Merged
Clarify fxl dimensions must be in first viewport meta tag#2503mattgarrish merged 2 commits intomainfrom
mattgarrish merged 2 commits intomainfrom
Conversation
rdeltour
approved these changes
Dec 13, 2022
iherman
approved these changes
Dec 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in w3c/epubcheck#1401, it's not clear in the authoring spec that the height and width have to be declared in the first
viewport metatag. The reading system spec requires reading systems to ignore subsequent definitions, so this pull request adds an authoring requirement to match.Making this explicit means we no longer have to talk about subsequent definitions in the authoring spec, since they can't be declared there.
I also switched "MUST NOT specify duplicate..." with "MUST NOT declare more than one..." for avoiding repeated definitions within a single tag. Not specifying "duplicate" dimensions sounds like it's okay if you have two declarations within a single tag so long as they have different values.
Preview | Diff