Made the epub:type restrictions explicit and adapted the RS#2380
Made the epub:type restrictions explicit and adapted the RS#2380
Conversation
I don't understand the point of this one, to be honest:
This looks like a relic of when we thought epub:type might influence assistive technologies. What is it going to do with terms it doesn't recognize and why do we care? I'd just erase it. |
|
It should be possible to write a test for the "must" you're adding in this PR, though. Since we know pop-up footnotes are implemented on at least a couple of RSes, make a test document that tries to make a meta tag a footnote and see if it works. It's not a perfect example of the requirement's restriction, but we only have to prove it can be done, right? |
Actually, I did not know about the footnotes being implemented... Let us see if this sketch for a test would work, containing two content files, p1 and p2
Is this what you mean? Which RS does implement a footnote with |
Happy to do it :-) |
iBooks was the first to implement them. You can read how to define them here: https://help.apple.com/itc/booksassetguide/en.lproj/itccf8ecf5c8.html Thorium also has the same. And just on a quick search there are some others like Calibre, Moon+, and even Kindle. I expect there are more, too. |
Brilliant! I have created two tests:
According to our spec, but also according to its earlier incarnations, the Is it o.k. to merge this PR? I will add the anchor to these two tests, too, it will save another PR. |
At least it's testable. I thought for sure they'd both ignore such a case, but I guess they aren't paying attention to where the semantic is set.
Looks fine to me now. |
Went roughly along the line of #2377 (comment).
In the §10 of the RS I was tempted to turn the two MUST-s into SHOULD-s; ignoring those terms is untestable in my view. But I did not do it for now
Fix: #2377
Preview | Diff