Note that data blocks are not scripted content#1409
Merged
Conversation
iherman
approved these changes
Nov 6, 2020
wareid
approved these changes
Nov 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1352 by adding a note to the scripting section that HTML data blocks do not represent scripted content.
The SVG case is a little murkier, as it says the element is the same as HTML but goes on to define things slightly differently. A script without a
typeis treated as javascript, otherwise the block is executed or not depending on whether the media type is recognized as a supported scripting language. That's not the same as HTML where everything outside of JS and 'module' types are data blocks.I added a sentence noting the same data block concept does not apply, but could in the future. We might just have to live with json in svg having to be set as scripted in the package for now. It's probably not a common case, though.
Preview | Diff