[css-view-transitions-1] When skipping transitions, call the DOM-update callback from a task#8827
Merged
khushalsagar merged 2 commits intow3c:mainfrom May 11, 2023
Merged
[css-view-transitions-1] When skipping transitions, call the DOM-update callback from a task#8827khushalsagar merged 2 commits intow3c:mainfrom
khushalsagar merged 2 commits intow3c:mainfrom
Conversation
Amend assert to allow calling the callback from a "done" state The "finished" promise is bound to the update callback promise, so it doesn't need to change (the update callback is async anyway). See [resolution](w3c#7904 (comment)). Closes w3c#7904
khushalsagar
approved these changes
May 11, 2023
Member
khushalsagar
left a comment
There was a problem hiding this comment.
Can you add a line to the change list at the end of the spec, describing this edit.
Collaborator
Author
Done |
Collaborator
Author
Thanks! Do you have merge permissions or do we need to tag someone else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amend assert to allow calling the callback from a "done" state
The "finished" promise is bound to the update callback promise, so it doesn't need to change (the update callback is async anyway).
See resolution.
Closes #7904
[css-spec-shortname-1] Brief description which should also include the #issuenum-or-URL and/or link to relevant CSSWG minutes.
Copy the above line into the Title and replace with the relevant details. Fill in any additional details here. See https://github.com/w3c/csswg-drafts/blob/master/CONTRIBUTING.md for more info.