Skip to content

Editorial Refactor of <color> Definition Section#7477

Merged
svgeesus merged 2 commits intow3c:mainfrom
fantasai:editorial-refactor-color-syntax
Jul 9, 2022
Merged

Editorial Refactor of <color> Definition Section#7477
svgeesus merged 2 commits intow3c:mainfrom
fantasai:editorial-refactor-color-syntax

Conversation

@fantasai
Copy link
Collaborator

@fantasai fantasai commented Jul 7, 2022 •
edited
Loading

Working my way through the spec top-to-bottom as a new reader, so, I notice these things...

  • Split out conceptual definitions from syntactic definitions, pulling the former up into the main section intro.
  • Define “color function” properly as a term.
  • Give an actual overview of all the color syntaxes in the intro, so readers have a map of what's coming.
  • Push legacy syntax into its own subsection.
  • Factor <alpha-value> into its own section, rather than as a paragraph of the rgb() section.
  • Shift non-normative text about hue angles into a note.

@fantasai
Copy link
Collaborator Author

fantasai commented Jul 8, 2022 •
edited
Loading

A couple things to be aware of:

  • Tried my best, but I'm not entirely sure I got the terminology exactly right in the intro text.
  • I'm not sure this is the right place to put the <alpha-value> definition, so maybe you want it somewhere else.
  • I think it's useful to have a listing with a brief description of each color function, so it's easy to get an overview of what's available and what it means, but it's maybe too much, so you may or may not want to keep it (or maybe want to put it somewhere else).

svgeesus
svgeesus requested changes Jul 8, 2022
View reviewed changes
svgeesus
svgeesus requested changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, better to have alpha in its own section rather than hanging off one of the spaces that happens to use it

@svgeesus
Copy link
Contributor

svgeesus commented Jul 8, 2022

Thanks, this is overall a nice improvement. A few small requests for changes.

fantasai added 2 commits July 8, 2022 13:11
@fantasai
[css-color-4][editorial] Refactor <color> syntax section
b563180 
* Split out conceptual definitions from syntactic definitions,
  pulling the former up into the main intro.
* Define “color function” properly as a term.
* Give an actual overview of all the color syntaxes in the intro,
  so readers have a map of what's coming.
* Push legacy syntax into its own subsection.
* Shift non-normative text about hue angles into a note.
@fantasai
[css-color-4] Factor out <alpha-value> into its own section.
9024a0d
@fantasai fantasai force-pushed the editorial-refactor-color-syntax branch from ae34411 to 9024a0d Compare July 8, 2022 18:16
@fantasai
Copy link
Collaborator Author

fantasai commented Jul 8, 2022

A few small requests for changes.

@svgeesus Done!

@svgeesus svgeesus self-requested a review July 9, 2022 09:58
svgeesus
svgeesus approved these changes Jul 9, 2022
View reviewed changes
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@svgeesus svgeesus merged commit eaab736 into w3c:main Jul 9, 2022
@fantasai fantasai deleted the editorial-refactor-color-syntax branch July 16, 2022 03:49
@GPHemsley GPHemsley mentioned this pull request Oct 6, 2022
Closed
@svgeesus svgeesus mentioned this pull request Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svgeesus svgeesus svgeesus approved these changes

Assignees

@svgeesus svgeesus

Labels

css-color-4 Current Work editorial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fantasai @svgeesus