[css-text-3] Disentangle content language and writing system#3202
Merged
frivoal merged 2 commits intow3c:masterfrom Nov 15, 2018
Merged
[css-text-3] Disentangle content language and writing system#3202frivoal merged 2 commits intow3c:masterfrom
frivoal merged 2 commits intow3c:masterfrom
Conversation
3954981 to
c2bdb4f
Compare
c2bdb4f to
c14fe8b
Compare
svgeesus
approved these changes
Nov 13, 2018
Contributor
svgeesus
left a comment
There was a problem hiding this comment.
These changes look great to me. Happy to approve for fonts 4, maybe someone else should also approve for text-3 (but the changes look good, and the clarification on normative appendix is very welcome)
Collaborator
Author
|
Thanks for checking in on the fonts part. @fantasai has taken a first quick look at the css-text part and found it generally satisfactory, but was planning to do a more careful second pass before merging, just to be sure. |
Collaborator
Author
|
Got a review from fantasai suggesting minor tweaks, which I have applied, so I merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2015