[css-pseudo-4] Simplified example of ::details-content#10476
Merged
Conversation
1. By depending on the animation rules defined in https://drafts.csswg.org/css-contain-3/#content-visibility-animation the step-end and step-start values are not needed. 2. 2. By depending on the change in whatwg/html#10265 (comment) and whatwg/html@fb3033a the `display: block` is no longer needed.
Contributor
Author
|
yisibl marked as non substantive for IPR from ash-nazg. |
dbaron
approved these changes
Jun 20, 2024
Member
dbaron
left a comment
There was a problem hiding this comment.
Indeed. This looks good -- I had too many places to try to make a similar change, and I didn't catch this one.
(Hopefully not needing display: block will stick, but it's possible that compatibility might require that we go back to requiring the display: block.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By depending on the animation rules defined in https://drafts.csswg.org/css-contain-3/#content-visibility-animation the step-end and step-start values are not needed.
By depending on the change in
Specify the rendering of <details> in more detail. whatwg/html#10265 (comment)
and
whatwg/html@fb3033a
the display: block is no longer needed.