Infrastructure: Move husky install to prepare script#2033
Merged
Conversation
4 tasks
Contributor
Author
|
@jesdaigle Any idea when this could go in? If not, I can work from a fork, but I would prefer not to if I can avoid that. |
zcorpan
approved these changes
Oct 29, 2021
Contributor
zcorpan
left a comment
There was a problem hiding this comment.
Rebased, CI checks are now green. The change LGTM, thanks!
Contributor
|
@WilcoFiers please confirm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is no longer recommended to use "postinstall" for Husky (see docs), and to use "prepare" instead.
postinstallscripts can not be guaranteed to run, and make it impossible to aria-practices into another project. The following will throw an error, because the postinstall is used rather than prepare: