Skip to content

Fix link position when header has attributes#1

Merged
vyskoczilova merged 1 commit intovyskoczilova:masterfrom
a-mt:master
Jan 13, 2020
Merged

Fix link position when header has attributes#1
vyskoczilova merged 1 commit intovyskoczilova:masterfrom
a-mt:master

Conversation

@a-mt
Copy link
Copy Markdown
Contributor

@a-mt a-mt commented Jan 9, 2020

The anchor isn't inserted at the right position if the header has attributes:

<h2 data-example="value">My title</h2>

becomes

<h2 <a href="#my-title" aria-hidden="true" class="aal_anchor" id="my-title"><svg aria-hidden="true" class="aal_svg" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path fill-rule="evenodd" d="M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z"></path></svg></a>data-example="value">My title</h2>

@vyskoczilova vyskoczilova merged commit 8d0b61e into vyskoczilova:master Jan 13, 2020
@vyskoczilova
Copy link
Copy Markdown
Owner

vyskoczilova commented Jan 13, 2020

Thanks a lot @a-mt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vyskoczilova vyskoczilova vyskoczilova approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-mt @vyskoczilova