Fallback to scanner to fetch confirmation info for external txs#82
Merged
altafan merged 2 commits intovulpemventures:masterfrom Feb 8, 2024
Merged
Fallback to scanner to fetch confirmation info for external txs#82altafan merged 2 commits intovulpemventures:masterfrom
altafan merged 2 commits intovulpemventures:masterfrom
Conversation
tiero
requested changes
Feb 2, 2024
Member
|
utACK |
louisinger
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds fallback strategy to fetch confirmation info of tx external to the wallet, ie not stored in the storage but fetched via blockchain scanner.
Unfortunately, there's no way we can use electrum's apis to get such info, so we have to fallback to esplora. For this, the usage of ESPLORA_URL env var has been revamped like follows:By default, the esplora URL is derived from the network, but it can be customized at will by specifying it withOCEAN_ESPLORA_URL. This way, ocean can be served in a dockerized env, like for example nigiri where the esplora URL becomes <container_name>:3001 instead of localhost.The blockchain scanner now returns tx confirmation info also for external txs.
Please @louisinger review.