Notify for utxos spent with and without confirmation#80
Merged
altafan merged 4 commits intovulpemventures:masterfrom Feb 1, 2024
Merged
Notify for utxos spent with and without confirmation#80altafan merged 4 commits intovulpemventures:masterfrom
altafan merged 4 commits intovulpemventures:masterfrom
Conversation
louisinger
reviewed
Feb 1, 2024
Contributor
louisinger
left a comment
There was a problem hiding this comment.
the utxos array is always transformed into utxo[0]: if I'm not wrong, I would drop the slice type if we always expect 1 element
louisinger
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, ocean was notifiyng clients about spent utxos only once they were confirmed in blockchain.
With the tiny refactor introduced with this, clients are notified about:
@louisinger please review this.