Refund failed swaps#519
Merged
Merged
Conversation
Co-authored-by: Marco Argentieri <tiero@users.noreply.github.com>
Updater deletes successful swaps from refundable swaps repository Only show tx is refundable after beeing confirmed Several bug fixes and improvements
Member
|
Test failing, conversion of types needed? @bordalix https://github.com/vulpemventures/marina/actions/runs/7385223231/job/20089560550 |
tiero
reviewed
Jan 2, 2024
Member
|
let's fix the CI and some left-over and LGTM |
tiero
reviewed
Jan 2, 2024
Member
|
resolve conflicts, merged reload button PR @bordalix |
tiero
reviewed
Jan 2, 2024
| try { | ||
| return (await axios.get(`${APIURL}/blocks/tip/height`)).data; | ||
| } catch (_) { | ||
| return 100; // running inside Github CI we don't have net access |
Member
There was a problem hiding this comment.
But you have Nigiri running, with a full Esplora instance
https://github.com/vulpemventures/marina/blob/master/.github/workflows/main.yml#L31-L35
Member
There was a problem hiding this comment.
also you know your are in CI via process.env.CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements refund of failed swaps.
Closes #514
There are 2 ways a user can refund a failed swap funding transaction:
Paste JSON received from Boltz:
{ blindingKey: <hex>, redeemScript: <hex> }In the case of a failed swap the funding transaction is marked as "Refundable" (visible on transaction list) and user is able to refund transaction after timelock expires.
@tiero please review