[fix] seckey_negate error on calculateScalarOffset #103
Merged
altafan merged 9 commits intoMay 22, 2023
Conversation
Collaborator
|
@louisinger did you check if there's something similar on elements core or other libs? |
Collaborator
Author
|
Merged
3 tasks
altafan
reviewed
May 22, 2023
altafan
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Input scalar are computed from
value,assetBlinder&valueBlinder. It happens that this set of values result into aZERO(0x00 * 32) scalarOffset. In such case, the privateNegate function throws an error.if
ZERO, skip de privateNegate call is enough to be able to blind the pset outputs.@altafan please review