Add withAll() and withAllRecursive() to Query Builder#94
Add withAll() and withAllRecursive() to Query Builder#94cuebit merged 8 commits intovuex-orm:masterfrom
withAll() and withAllRecursive() to Query Builder#94Conversation
|
Hey @kiaking I reverted the changes to If you run the test, you'll see that one is failing at: https://github.com/M3psipax/vuex-orm-next/blob/97e6ee8af47dfbb25e53127fa6d4ef43cbb3a297/test/feature/relations/eager_loads/eager_loads.spec.ts#L67 When loading only top level relations, I would expect all further relations to be filled with |
|
Okay, I adjusted the test to allow |
Co-Authored-By: M3psipax <15832631+M3psipax@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 38 +2
Lines 1122 1175 +53
Branches 164 172 +8
=========================================
+ Hits 1122 1175 +53
Continue to review full report at Codecov.
|
|
Hey, thanks for merging. When is the next release planned? |
|
As soon as the docs for this feature is ready, we can release a new version 👍 👀 @cuebit 😃 |
Type of PR:
Breaking changes:
Details
Adds
withAll()andwithAllRecursive()utility methods to fetch all relationships on a model.Still needs a lot more unit tests though.