fix: normalization error on nested relationship#61
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 834 834
Branches 134 134
=========================================
Hits 834 834
Continue to review full report at Codecov.
|
74c7493 to
e65188f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A model with more than 2 related models related to the same model was causing a normalization error. It was due to the Schema class was caching the first created schema with its key.
For example, the first relation creates a schema and say its name is
proposal_settings. Now the parent of this model isproposal_templates, because it's defined first in Opportunity model.Next, if the
proposalsmodel also depends onproposal_settings, but because the schema forproposal_settingsis already created byproposal_templates, it uses the sameproposal_settingsschema. Now we have problem because the parent model this time should beproposalsbut it's using the previousproposal_templates.We've fixed this by caching the schema with
modelANDparententity name. So only when the model and the parent name match, we use the cache.Type of PR:
Breaking changes: