Codecov Report

Merging #58 (2fbafa9) into master (44c4303) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines          823       824    +1     
  Branches       132       131    -1     
=========================================
+ Hits           823       824    +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c4303...2fbafa9. Read the comment docs.

Methods such as insert, fresh, etc, all normalize the records and null indexes are successfully asserted. Since the aforementioned assertion takes place in the Schema class, non-normalized records will always return null for missing indexes. This means non-normalizing persist methods, such as add, replace, etc, will not throw in the absence of a key, particularly in the case for composite keys which results in inconsistent behavior.

@kiaking in this regard, unless this is expected behavior, can you think of any side-effects of moving this assertion to the $getIndexId() method?

Oh yeah this is not expected behavior. The null id should always throw unless it's set as UID.

And yeah I think it makes sense to move the assertion to the $getIndexId() method! Would you like to include that in the PR?