Skip to content

feat: Add support for multiple databases#53

Merged
kiaking merged 2 commits intovuex-orm:masterfrom
brinkmanlab:multidb
Apr 28, 2021
Merged

feat: Add support for multiple databases#53
kiaking merged 2 commits intovuex-orm:masterfrom
brinkmanlab:multidb

Conversation

@innovate-invent
Copy link
Copy Markdown
Contributor

@innovate-invent innovate-invent commented Apr 1, 2021

This is from a discussion with @kiaking and @cuebit on the Slack.

Type of PR:

  • Bugfix
  • Feature
  • Refactor
  • Code style update
  • Build-related changes
  • Test
  • Documentation
  • Other, please describe:

Breaking changes:

  • No
  • Yes

Details

This adds support for multiple namespaces.
Repositories or Models can be registered and accessed under multiple namespaces via store.$repo(Model, 'namepace').
Some classes now retain the database rather than the store.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2021

Codecov Report

Merging #53 (da4445d) into master (c947929) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines          823       894   +71     
  Branches       132       150   +18     
=========================================
+ Hits           823       894   +71     
Impacted Files Coverage Δ
src/connection/Connection.ts 100.00% <100.00%> (ø)
src/database/Database.ts 100.00% <100.00%> (ø)
src/interpreter/Interpreter.ts 100.00% <100.00%> (ø)
src/model/Model.ts 100.00% <100.00%> (ø)
src/query/Query.ts 100.00% <100.00%> (ø)
src/repository/Repository.ts 100.00% <100.00%> (ø)
src/store/Store.ts 100.00% <100.00%> (ø)
src/schema/Schema.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c947929...da4445d. Read the comment docs.

@innovate-invent innovate-invent force-pushed the multidb branch 10 times, most recently from 069936a to 7e93307 Compare April 1, 2021 05:41
@innovate-invent innovate-invent marked this pull request as ready for review April 1, 2021 05:42
@innovate-invent innovate-invent changed the title Add support for multiple databases feat: Add support for multiple databases Apr 1, 2021
@kiaking
Copy link
Copy Markdown
Member

kiaking commented Apr 26, 2021

Thanks for the PR! Looking nice! I would like to make an adjustment to increase the test coverage. Could you change your PR repo setting to accept push?

@innovate-invent
Copy link
Copy Markdown
Contributor Author

I don't understand why some forks allow pushes to PRs and others don't. It is always selected when available when opening the PR...
I have simply added you to the repository.
Thanks for your help.

@cuebit cuebit added the enhancement New feature or request label Apr 26, 2021
@kiaking kiaking merged commit c319b3a into vuex-orm:master Apr 28, 2021
@kiaking kiaking deleted the multidb branch April 28, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants