fix(VTab): disabled tab can be reached by keyboard#14606
Merged
KaelWD merged 1 commit intovuetifyjs:masterfrom Jan 25, 2022
Merged
fix(VTab): disabled tab can be reached by keyboard#14606KaelWD merged 1 commit intovuetifyjs:masterfrom
KaelWD merged 1 commit intovuetifyjs:masterfrom
Conversation
KaelWD
approved these changes
Jan 25, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If vTab is disabled I set the
tabindexto-1, means that the element is not reachable via sequential keyboard navigation.fixes #14601
Motivation and Context
This PR solves the problem present on the vTab component which can be focused by the keyboard even if is disabled.
(see the reproduction in #14601)
How Has This Been Tested?
Markup:
Details
Types of changes
Checklist:
masterfor bug fixes and documentation updates,devfor new features and backwards compatible changes andnextfor non-backwards compatible changes).