fix(VTabs): prevent selection of disabled tabs#14229
Merged
KaelWD merged 4 commits intovuetifyjs:masterfrom Oct 31, 2021
Merged
fix(VTabs): prevent selection of disabled tabs#14229KaelWD merged 4 commits intovuetifyjs:masterfrom
KaelWD merged 4 commits intovuetifyjs:masterfrom
Conversation
KaelWD
requested changes
Oct 12, 2021
Member
KaelWD
left a comment
There was a problem hiding this comment.
Disabled tabs can still be activated with the keyboard
Contributor
Author
|
Hi @KaelWD, update the PR with a change at |
KaelWD
approved these changes
Oct 31, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The problem I found on codebase is that whenever a
v-tabis disabled the event propagation still happens on child elements because ofpointer-eventsloses its inheritance.Proper way I found to fix this was by adding the subsequent child elements to its list by overriding others
pointer-eventsthat could appear, e.g.v-badgefixes #13728
Motivation and Context
The change itself helps fixing an UI behavior (#13728)
How Has This Been Tested?
Tested by using it on Chrome 94, Firefox 92 and Safari 15
Markup:
Details
Types of changes
Checklist:
masterfor bug fixes and documentation updates,devfor new features and backwards compatible changes andnextfor non-backwards compatible changes).