fix(VFileUpload): adding/replacing files with dropzone click#22741
Merged
J-Sek merged 3 commits intovuetifyjs:v3-stablefrom Mar 23, 2026
Merged
Conversation
Contributor
|
J-Sek
requested changes
Mar 21, 2026
Contributor
J-Sek
left a comment
There was a problem hiding this comment.
At the very least, we should avoid breaking "inset" variant. The clearing is up for analysis and might need some discussion.
Contributor
Author
|
J-Sek
approved these changes
Mar 23, 2026
J-Sek
pushed a commit
that referenced
this pull request
Mar 23, 2026
- drop area should still be clickable after file selection (unless it shows the files within) - accidental click should not clear the field (this behavior is aligned with other UI frameworks) resolves #22737
This was referenced Mar 23, 2026
poettig
reviewed
Mar 23, 2026
| 'v-file-upload-dropzone', | ||
| { | ||
| 'v-file-upload-dropzone--clickable': !hasBrowse && !hasFiles, | ||
| 'v-file-upload-dropzone--clickable': !hasBrowse, |
There was a problem hiding this comment.
Question: Shouldn't this have the same condition as the onClick-Listener?
Contributor
Author
There was a problem hiding this comment.
With the inset-file-list prop enabled, this section gets hidden when a file is selected, so we don't need to apply the logic here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The file upload input component previously checked if the
hasBrowseandhasFilesis enabled and subsequently disables the click handler. This created a weird behaviour where users are not able to select a different file after the first selection. This PR removes thehasFilescheck to allow users click the file upload to re-upload another fileResolves #22737
Markup: