fix(hotkey): resilient sequence parsing#22704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces whatever was going on before with a proper recursive parser.
+-/_literals are now valid.useHotkey and VHotkey now treat separators the same.
VHotkey displays
/as "or" instead of "/".fixes #22399
Incorrect or inconsistent documentation:
/was added as "or" in VHotkey (2369274) but not handled correctly in useHotkey. The exampleup/downdoesn't make much sense for a combination.This was never actually done by either VHotkey or useHotkey as far as I can tell.
It was trivial to add to the parser but VHotkey still uses spaces to separate sequences so one of these will have to change for consistency.Has been removed. There is explicit support for space literals (orctrl+) butctrl + sis an error.Not fixed:
a+b, only the last one is used.+is shift+= on ANSI-US keyboards/is shift+7 on ISO-DEshift+=on ANSI-US -e.keyis+so onlyshift++will workMarkup: