fix(hotkey): add delimiter aliases without delimiter ambiguity#22635
Merged
fix(hotkey): add delimiter aliases without delimiter ambiguity#22635
Conversation
Preserve unambiguous parsing by keeping delimiter characters syntax-only while allowing literal '+' via aliases. Also document delimiter rules and cover the new behavior with parser, composable, and component tests.
Remove explicit '+' display map entry because alias normalization already resolves plus and unknown keys render safely via text fallback.
Add support for 'slash' and 'underscore' as aliases for literal keys, improving the hotkey parsing functionality. Update documentation to reflect these changes and clarify delimiter syntax rules. Enhance tests to cover new alias behavior and ensure proper handling of key combinations.
Contributor
|
I think it's worth to update https://github.com/vuetifyjs/0 as well, it's based mostly on big vuetify implementation |
Wrap the delimiter validation condition for slash support to comply with project max-len rules without changing behavior.
J-Sek
approved these changes
Mar 8, 2026
J-Sek
pushed a commit
that referenced
this pull request
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
plusas a hotkey alias so literal+can be bound without treating+as interchangeable with delimitersslashas a hotkey alias so literal/can be bound without treating/as interchangeable with delimitersunderscoreas a hotkey alias so literal_can be bound without treating_as interchangeable with delimiters+,_,/for combinations and-for sequences), and add regression coverage for ambiguous patterns likealt+++b+hFixes #22399