Conversation
Member
|
Why 18,12 instead of 16,8? |
Contributor
Author
Tested on the home page and it looks better with 12. Other than this, I don't have much more to back it. We can go with 16/8 if you feel it is going to match with other use cases better. If we keep it, the only minor change would be to drop recommending |
Member
Contributor
Author
Member
|
My main justification for 8px is that's what we already had with |
Contributor
Author
|
KaelWD
reviewed
Feb 3, 2026
KaelWD
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Effective change:
no-gutter$form-grid-gutter$grid-guttersto avoid confusion