Conversation
4613cae to
f570094
Compare
4e8d329 to
cd08fdf
Compare
Member
|
Does not address the main point of #14198 (changing surface color in dark theme). I think this was one of the original goals for the |
cd08fdf to
a80f7f3
Compare
Contributor
Author
|
I am experimenting with elevation-overlay that would work well for dark mode. Similar trick as in MUI. Requires opt-in by adding CSS class. |
d1661f7 to
4cbf812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.elevation-overlayclass meant to help with dark modePost-implementation tasks:
resolves #14198
Markup: