Conversation
Member
This will break a lot of layouts which is why I put the issue on a major milestone not 3.9.0. Still unsure what the impact of this will be, we need to check a bunch of real examples and see if it's possible to make the required changes automatically. |
KaelWD
reviewed
Jun 2, 2025
KaelWD
reviewed
Jun 2, 2025
d7c6f09 to
29d1a1a
Compare
6331ca7 to
564ccc8
Compare
a7fa817 to
2e2cddb
Compare
42efc73 to
c905f05
Compare
Drop negative margins in favor of gap and gap-aware calculations
remove deprecated props and convert grid alignment, justify, and ordering to use utility classes update documentation and tests to reflect changes
Contributor
|
Member
|
I cleaned it up a bit then broke it more,
|
Member
<template>
<v-container>
<v-row>
<v-col md="4">xs: grow, md: 4</v-col>
<v-col>grow</v-col>
</v-row>
<v-row>
<v-col cols="4" md>xs: 4, md: grow</v-col>
<v-col>grow</v-col>
</v-row>
<v-row>
<v-col cols="auto" md="4">xs: auto, md: 4</v-col>
<v-col>grow</v-col>
</v-row>
<v-row>
<v-col cols="4" md="auto">xs: 4, md: auto</v-col>
<v-col>grow</v-col>
</v-row>
<v-row>
<v-col cols="4" md="12">xs: 4, md: 12</v-col>
</v-row>
<v-row>
<v-col cols="4" offset-md="4">offset-md: 4</v-col>
<v-col>grow</v-col>
</v-row>
</v-container>
</template>
<style>
.v-col {
outline: 1px solid red;
}
</style> |
Contributor
|
We can push it even more into parsing Following example already works, but is too much noise. <v-row>
<v-col cols="1" style="--v-row-columns: 5">1/5</v-col>
<v-col cols="1" style="--v-row-columns: 5">1/5</v-col>
<v-col cols="1" style="--v-row-columns: 2">1/2</v-col>
<v-col cols="1" style="--v-row-columns: 10">1/10</v-col>
</v-row>
|
Contributor
|
The last thing that bothers me is that "auto" all over the docs examples instead of "grow". It should be fixed in |
J-Sek
previously approved these changes
Jan 29, 2026
KaelWD
reviewed
Jan 30, 2026
Partially reverts 2b37b8f
This was referenced Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8611, related to #18846
This PR:
gapprop adding more control over spacingdenseandno-guttersprops in favor of widely adopteddensitypropalign,justify,order, etc.)Docs are also updated (both examples and app itself)
Markup: