fix(cli): cleanup writeTemp on dev server restart#1693
Merged
Conversation
Pull Request Test Coverage Report for Build 23278477878Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR addresses dev server restarts by adding a cleanup mechanism to the writeTemp utility so its internal cache can be cleared, and adds a regression test to ensure the cache reset causes unchanged content to be written again.
Changes:
- Extend
AppWriteTempto include acleanup()method and implement it inresolveAppWriteTemp()by clearing the internal cache. - Call
app.writeTemp.cleanup()duringvuepress devrestart. - Add a unit test covering “rewrite after cleanup” behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/core/tests/app/resolveAppWriteTemp.spec.ts | Adds a test asserting cleanup clears the cache so unchanged content is written again. |
| packages/core/src/types/app/utils.ts | Changes AppWriteTemp from a function type to a callable interface with a cleanup() method. |
| packages/core/src/app/resolveAppWriteTemp.ts | Attaches cleanup() to the writeTemp function and clears the internal cache map. |
| packages/cli/src/commands/dev/dev.ts | Invokes app.writeTemp.cleanup() as part of the restart flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
meteorlxy
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.