Conversation
Pull Request Test Coverage Report for Build 22886476298Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR fixes the chokidar file watcher's ignored callback in VuePress's dev server page watcher. The main change improves directory-level filtering by separating the ignore logic into a dedicated picomatch matcher for ignored directories and a page matcher for file-level filtering, ensuring that directories like node_modules and .vuepress are immediately ignored without traversing their children.
Changes:
- Split the single picomatch matcher (with
ignoreoption) into two separate matchers:ignoreMatcherfor directory-level exclusion andisPageMatchfor file matching - Restructured the
ignoredcallback to first checkignoreMatcher, then check temp/cache directories (guarded byisDirectory()), and finally check file pattern matching - Changed temp/cache directory comparison from
startsWithto strict equality, which is correct since ignored directories are not traversed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
meteorlxy
reviewed
Mar 9, 2026
Mister-Hope
commented
Mar 9, 2026
meteorlxy
previously approved these changes
Mar 10, 2026
meteorlxy
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.