packages/core/src/fieldset/legend/FieldsetLegend.test.ts (1)

72-98: Add a companion test for active legend unmount behavior.

Please add one more case defining expected behavior when the active legend unmounts while another legend is still mounted (should it clear or transfer aria-labelledby). This will lock in the full lifecycle contract.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/core/src/fieldset/legend/FieldsetLegend.test.ts` around lines 72 -
98, Add a companion test that verifies behavior when the active legend unmounts
and another legend remains: create a TestComponent using FieldsetRoot and
FieldsetLegend like the existing test but start with only the main legend
mounted, then set showExtra to true so the extra legend mounts after main
(making the extra legend the active one), assert the fieldset aria-labelledby
points to the newly mounted extra legend, then set showExtra back to false to
unmount the active extra legend and assert aria-labelledby transfers back to the
remaining legend (legend-main); reference the same symbols FieldsetRoot,
FieldsetLegend, showExtra, TestComponent and the fieldset variable in the new
test.

packages/core/src/utils/useTimeout.ts (1)

19-22: Prefer portable timer ID typing instead of double-casting.

Line 22's as unknown as TimeoutId bypasses type safety. Use ReturnType<typeof setTimeout> (and a null sentinel) to keep this SSR-safe and avoid unsafe casts. This applies to the timer logic across lines 19–22 and 29–32.

♻️ Suggested refactor

-type TimeoutId = number
-
-const EMPTY = 0 as TimeoutId
+type TimeoutId = ReturnType<typeof setTimeout> | null
+
+const EMPTY: TimeoutId = null
@@
-    this.currentId = setTimeout(() => {
+    this.currentId = setTimeout(() => {
       this.currentId = EMPTY
       fn()
-    }, delay) as unknown as TimeoutId
+    }, delay)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/core/src/utils/useTimeout.ts` around lines 19 - 22, The timer IDs
are being double-cast with "as unknown as TimeoutId" for this.currentId in the
setTimeout callback (and similarly in the clear/reset logic around the other
timer assignments), which bypasses type safety; change the type of currentId to
use ReturnType<typeof setTimeout> | null (use null as the sentinel instead of
EMPTY) and assign setTimeout directly without casts, updating any checks/clears
(e.g., places referencing currentId, the setTimeout call, and the clearTimeout
usage around lines like the setTimeout and clear/reset blocks) to handle null
safely and call clearTimeout(currentId) only when currentId is not null.