feat($markdown): make page suffix configurable (close #2452)#2674
Merged
billyyyyy3320 merged 2 commits intovuejs:masterfrom Nov 10, 2020
dennisreimann:page-suffix
Merged
feat($markdown): make page suffix configurable (close #2452)#2674billyyyyy3320 merged 2 commits intovuejs:masterfrom dennisreimann:page-suffix
billyyyyy3320 merged 2 commits intovuejs:masterfrom
dennisreimann:page-suffix
Conversation
Contributor
Author
|
As this potentially fixes the issues #2420 and #2424 – maybe the authors @davidgiga1993 and @chengyuhui can help verify, that this fixes the problems they mentioned. Also cc @cwaring :) |
Contributor
Author
|
Let me know if something is unclear here – other than that it'd be good to get some feedback on whether or not this fixes the mentioned issues. Would love to see this merged :) |
Collaborator
|
Overall LGTM. |
billyyyyy3320
approved these changes
Nov 10, 2020
|
Thanks for making this happen @dennisreimann & @billyyyyy3320 🥳 |
easeev
reviewed
Jan 21, 2021
| - Type: `string` | ||
| - Default: `.html` | ||
|
|
||
| Option to customize internal links to be compatible when using the [vuepress-plugin-clean-urls](https://vuepress.github.io/en/plugins/clean-urls/). |
There was a problem hiding this comment.
The link is broken. Correct one: https://vuepress-community.netlify.app/en/plugins/clean-urls/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the markdown link plugin with an option for the page suffix, which is currently hardcoded to
.html.This fixes broken links in the markup (and hence non-js version) when using the clean urls plugin. See #2452 for details.
Fixes #2452.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
Other information:
See the associated feature request issue for detailed description and previous discussion.