fix($core): add missing styles for <OutboundLink />#2662
Merged
billyyyyy3320 merged 1 commit intovuejs:masterfrom Oct 14, 2020
Mister-Hope:master
Merged
fix($core): add missing styles for <OutboundLink />#2662billyyyyy3320 merged 1 commit intovuejs:masterfrom Mister-Hope:master
<OutboundLink />#2662billyyyyy3320 merged 1 commit intovuejs:masterfrom
Mister-Hope:master
Conversation
<OutboundLink />
billyyyyy3320
approved these changes
Oct 14, 2020
Contributor
Author
|
Could you please publish 1.7.1 for this? Because it's affecting all third party theme which is not using theme extending and extend the default theme? |
Member
|
Not all theme is using stylus, so it's not a good idea to write stylus code in core package. See #1482 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2627 adds a hint with
sr-onlyclass, but the class style is placed in@vue/theme-defaultby mistake.OutboundLink is an internal component, and will effect all the themes, so the style must be placed in the component.