fix($core): #2627 Dup ID violates HTML5-4#2650
Merged
bencodezen merged 4 commits intovuejs:masterfrom Oct 13, 2020
Merged
Conversation
1 task
ktquez
reviewed
Oct 9, 2020
ktquez
reviewed
Oct 9, 2020
|
@adico1 .sr-only {
position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
clip: rect(0, 0, 0, 0);
white-space: nowrap;
border-width: 0;
} |
ktquez
approved these changes
Oct 10, 2020
bencodezen
approved these changes
Oct 13, 2020
Member
bencodezen
left a comment
There was a problem hiding this comment.
Thanks for your work on this @adico1!
Contributor
|
I don't think this hint is necessary and it's looking good. |
Contributor
|
Hey, I found the problems, it's a internal plugin, why are you placing styles in theme-default? It should be placed under Outboundlink. Otherwise you are breaking every theme which is not extending @vue/theme-default!!! That will inflect all the docs site which is using CI to update deps for auto-publishing while not using theme-default or a theme extending it. I will make a PR to fix this. Hope you can release 1.7.1 to fix it! |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: