fix: adds accessibility to code-group component#2630
fix: adds accessibility to code-group component#2630bencodezen merged 1 commit intovuejs:masterfrom lbenie:fix/code-group
Conversation
d-pollard
left a comment
There was a problem hiding this comment.
Do you happen to have an a11y resource that would explain how this improves accessibility vs what was previously there?
Other than the comment I made, it looks good!
packages/@vuepress/theme-default/global-components/CodeGroup.vue
Outdated
Show resolved
Hide resolved
Sure! Some guidelines about Since the component is Although thinking on the nav element should be removed since it relates to navigation links. I'll update the PR to remove the |
|
I've updated the PR with the requested changes let me know if I need to do something else :) |
d-pollard
left a comment
There was a problem hiding this comment.
Looks good! Thank you for making these changes!
|
Thanks @lbenie for your work on this! Appreciate it! |
Summary
Fixes the
code-groupcomponent by wrapping the buttons in a list for accessibility purpose.What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Before on the left
After on the right
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: