fix: sidebar groups are not opened when directly navigating to these pages (fix #2564)#2565
Merged
billyyyyy3320 merged 2 commits intovuejs:masterfrom Feb 18, 2021
Merged
Conversation
Contributor
Author
Contributor
Author
|
@billyyyyy3320 Thanks for taking a look at this PR! Is there anything blocking this from being merged? |
Contributor
Author
|
@billyyyyy3320 Could this PR be merged soon? It would help a lot for nested pages |
| } | ||
| }) | ||
| }) || item.path && isActive(route, item.path) | ||
| } |
Collaborator
There was a problem hiding this comment.
Sorry for the very late review. Thanks for the PR, and the functionality looks good to me.
Only a small suggestion, there're too many conditions without comments and variable names for others to understand. Would you like to try the code below
function descendantIsActive (route, item) {
if (item.type === 'group') {
const childIsActive = item.path && isActive(route, item.path)
const grandChildIsActive = item.children.some(child => {
if (child.type === 'group') {
return descendantIsActive(route, child)
} else {
return child.type === 'page' && isActive(route, child.path)
}
})
return childIsActive || grandChildIsActive
}
return false
}
Contributor
Author
There was a problem hiding this comment.
Thanks, I think that's much clearer. I've implemented your suggestion.
This was referenced Mar 15, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: