fix(vscode): use regex for TS extension patching to support VS Code 1.110+#5983
Merged
johnsoncodehk merged 1 commit intovuejs:masterfrom Mar 11, 2026
Merged
Conversation
8841347 to
84f9e7d
Compare
Member
|
LGTM, thanks! |
|
Thank you. For users still using Vue 2. Does the |
I can confirm. 3.0.8 does not work with VS Code 1.110+. We're also maintaining a Vue 2.7 app, so upgrading to 3.1+ isn't an option. Would it be possible to backport this fix to a 3.0.x release? |
Member
|
You can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsbtotsgo(Use ts-go for building our extensions microsoft/vscode#292461), changing the minified variable names in the built-in TypeScript extension'sdist/extension.jspatchTypeScriptExtension()no longer matched, causing the monkey-patches to silently fail.vuefiles, becauseisSupportedLanguageModeno longer includedvueThis PR replaces the four hardcoded string replacements with regex-based patterns that match identifier names regardless of minification, supporting both the old format (
t.typescript,t.jsTsLanguageModes) and the new format (bl,Oh).Fixes #4221 (comment)