fix(language-service): provide data for all default html tags#5967
Closed
liangmiQwQ wants to merge 2 commits intovuejs:masterfrom
Closed
fix(language-service): provide data for all default html tags#5967liangmiQwQ wants to merge 2 commits intovuejs:masterfrom
liangmiQwQ wants to merge 2 commits intovuejs:masterfrom
Conversation
Member
|
How to reproduce the situation? |
Contributor
Author
<template>
<img>
<img>
<div />
<div />
</template>
However, this seems to happen randomly sometimes, sometimes the outline become normal after I do some edit to the file, sometimes it still acts wrongly, sometimes the situation only shows when I set |
Member
|
|
Contributor
Author
|
Idk why, but... 
|
Member
|
I cannot reproduce this behavior, but I think that this issue is caused by us not running |
Contributor
Author
|
let me do some experiments after dinner.... and thank you so much! |
Contributor
Author
Trace on #5968. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, only tags
getComponentsAndElementsreturned can be returned inprovideTagsfn, and it seems caused issues, like some void tags, will process incorrect document symbols without data provider returning (like this)To be honest, I feel quite strange when I making up this PR, I first wonder why
getComponentsAndElementsdoesn't returnimgand I did some debug, found the only one tag this function return is[ "Vue" ]for a no-script SFC, I don't know howtsserverwork, but I think it's really strange. And at the same time, I also wonder whyprovideTagsadded all tags inbuiltInDatabutdefaultHtmlTagsdoesn't