feat: Improve Typed Slots Support#2547
Merged
johnsoncodehk merged 9 commits intomasterfrom Mar 26, 2023
Merged
Conversation
This was
linked to
issues
Mar 26, 2023
Closed
KaelWD
reviewed
Mar 27, 2023
| : T extends { children?: infer S } ? { [K in keyof S]-?: S[K] extends ((obj: infer O) => any) | undefined ? O : any } | ||
| : T extends { ${slots}?: infer S } ? S | ||
| : T extends { children?: infer S } ? S | ||
| : T extends { [K in keyof PickNotAny<JSX.ElementChildrenAttribute, {}>]?: infer S } ? S |
There was a problem hiding this comment.
- Shouldn't this be first? DefineComponent always has $slots but the default value is essentially
any, so ElementChildrenAttribute will never be checked. ElementChildrenAttributeis a property on the elements' props. In vue that's$props, soJSX.ElementAttributesPropertyalso needs to be used. The slots will be onT[keyof JSX.ElementAttributesProperty][keyof JSX.ElementChildrenAttribute]
|
This doesn't seem to solve my other problem either, slots from .vue files are still not accessible from tsx: // Comp.vue
<script setup lang="ts"></script>
<template>
<slot name="activator" :isActive="false" />
</template>// test.tsx
import Comp from './Comp.vue'
const el = (
<Comp>
{{ activator: props => props.isActive }}
</Comp>
)Same cause though, volar is defining |
Was this specific issue ever fixed? I'm still having the same problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typed Slot Children Support(delay)defineSlots Support(delay)