Skip to content

[proposal] Register typescript commands in takeover mode #2361

@zardoy

Description

@zardoy

The request is to register command IDs listed below so:

  1. User don't need to create second keymap for the same commands when takeover mode is enabled
  2. Preserve compatibility with other extensions (eg commands.run pipelines)

All in all why don't just do this? The only case I know that can cause warnings is that when builtin typescript extension is enabled after takeover mode was enabled, but we can un-register commands then?

The only command I actually care is only typescript.tsserverRequest for API. I believe it was already discussed hundred of times, but AFAIK this is the only to communicate with TS plugin (pass and receive arbitrary data).

Also ideally handle all commands:

  • typescript.findAllFileReferences -> volar.vue.findAllFileReferences
  • typescript.goToProjectConfig -> volar.openTsConfig
  • typescript.goToSourceDefinition -> ?
  • typescript.organizeImports -> ?
  • typescript.removeUnusedImports -> ?
  • typescript.selectTypeScriptVersion -> volar.selectTypeScriptVersion

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions