packages/runtime-core/src/components/Teleport.ts (2)

172-180: ⚠️ Potential issue | 🟠 Major

Invalidate the queued target mount when this Teleport is discarded.

A same-root pending update can remove or replace this Teleport without clearing the old callback from the parent suspense's buffered effects. In that case, Lines 177-180 will still run on resolve and call mountToTarget(), which can resurrect stale teleported DOM in target. Please add a vnode-local invalidation guard and clear it from remove().

🛡️ Example guard

       ) {
         n2.el!.__isMounted = false
         queuePostRenderEffect(() => {
+          if (n2.el!.__isMounted !== false) return
           mountToTarget()
           delete n2.el!.__isMounted
         }, parentSuspense)
       } else {

Also clear that flag from remove() when a pending teleport is discarded.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/runtime-core/src/components/Teleport.ts` around lines 172 - 180, Add
a vnode-local invalidation guard so the queued post-render callback for Teleport
checks whether this Teleport was discarded before running mountToTarget: when
scheduling queuePostRenderEffect in the Teleport mount branch (where
isTeleportDeferred or parentSuspense pendingBranch is true) set a flag on the
vnode (e.g. n2.__pendingTeleport = true) and have the queued function
early-return if that flag is falsy; then ensure the flag is cleared in the
Teleport remove() path (e.g. delete n2.__pendingTeleport) so
cancelled/vnode-replaced Teleports cannot run mountToTarget after being removed.

---

185-203: ⚠️ Potential issue | 🔴 Critical

Carry the DOM refs through the deferred patch path.

The early return at Lines 189-203 happens before n2 inherits el/anchor/target refs from n1. One pre-resolve update still works because the queued retry closes over the original vnode, but a second update before resolution will patch from a Teleport whose el was never assigned and throw on n1.el!.__isMounted. Copy the refs before re-queueing.

🔁 Minimal fix

       if (n1.el!.__isMounted === false) {
+        n2.el = n1.el
+        n2.anchor = n1.anchor
+        n2.targetStart = n1.targetStart
+        n2.targetAnchor = n1.targetAnchor
+        n2.target = n1.target
         queuePostRenderEffect(() => {
           TeleportImpl.process(
             n1,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/runtime-core/src/components/Teleport.ts` around lines 185 - 203,
Before early-returning and queueing the deferred retry in Teleport.ts, copy DOM
refs from the old vnode to the new vnode so later retries have valid refs: set
n2.el = n1.el, n2.anchor = n1.anchor and n2.target = n1.target (and any other
teleport-specific ref fields) immediately before calling queuePostRenderEffect
and returning. This change should be made in the code path that checks
n1.el!.__isMounted === false and uses queuePostRenderEffect/TelportImpl.process
so the queued closure operates on a vnode with the correct DOM references.